[Mesa-dev] [PATCH 1/2] i965/fs: Recalculate live intervals in calculate_register_pressure().

Matt Turner mattst88 at gmail.com
Sat Mar 29 21:59:04 PDT 2014


On Sat, Mar 29, 2014 at 7:14 PM, Eric Anholt <eric at anholt.net> wrote:
> Matt Turner <mattst88 at gmail.com> writes:
>
>> Otherwise calling dump_instructions() after declaring a new fs_reg would
>> segfault when calculate_register_pressure()'s loop over reg walked off
>> the end of the virtual_grf_start[] array that calculate_live_intervals()
>> would have reallocated for you, if it had known there was a new
>> register.
>
> Should we just invalidate from virtual_grf_alloc(), to solve the problem
> in general?

I don't think we need to go that far, since calculate_live_intervals
isn't going to be called in weird places except for calling
dump_instructions from gdb.


More information about the mesa-dev mailing list