[Mesa-dev] [PATCH v2 0/9] Add ARB_query_buffer_object (swrast)

[Ian Romanick]

Patches 1, 2, and 4 through 9 are

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

I sent a comment on patch 3.

The comment on patch 2 is more FYI than anything.

On 03/27/2014 01:59 PM, Rafal Mielniczuk wrote:
> Hello,
> 
> This is the second version of the series implementing 
> ARB_query_buffer_object in mesa.
> 
> Main changes to the first version are:
>  - Enable extension only for software driver
>  - Fix possible segfault in patch #7
>  - Fix typos and comment style issues
>  
> Drivers, which are not able to implement it without
> CPU roundtrip can just mark extension flag as true
> and use software fallback.
> 
> I did not add any ctx.Driver callback for now, as I was 
> not sure what would be the required api there. 
> Perhaps it would be better to add this while implementing 
> gpu acceleration in driver?
> 
> I tested the extension by enabling software fallback in i965 driver.
> This is not included in this series.
> 
> Thanks,
> Rafal Mielniczuk (9):
>   glapi: Add xml infrastructure for ARB_query_buffer_object
>   mesa: Add ARB_query_buffer_object extension flag
>   mesa: Add QueryBuffer to context
>   mesa: Handle QUERY_BUFFER_BINDING in GetIntegerv
>   mesa: Handle QUERY_RESULT_NO_WAIT in GetQueryObject{ui64}v
>   mesa: Fix typos in function names in queryobj
>   mesa: Implement software fallback for ARB_query_buffer_object
>   mesa: Enable GL_ARB_query_buffer_object for software drivers
>   doc: mark GL_ARB_query_buffer_object as done for swrast
> 
>  docs/GL3.txt                                   |   2 +-
>  src/mapi/glapi/gen/ARB_query_buffer_object.xml |  18 ++++
>  src/mapi/glapi/gen/Makefile.am                 |   1 +
>  src/mapi/glapi/gen/gl_API.xml                  |   4 +
>  src/mesa/main/bufferobj.c                      |   5 ++
>  src/mesa/main/extensions.c                     |   2 +
>  src/mesa/main/get.c                            |   5 ++
>  src/mesa/main/get_hash_params.py               |   3 +
>  src/mesa/main/mtypes.h                         |   3 +
>  src/mesa/main/queryobj.c                       | 109 +++++++++++++++++++++----
>  10 files changed, 135 insertions(+), 17 deletions(-)
>  create mode 100644 src/mapi/glapi/gen/ARB_query_buffer_object.xml
>