[Mesa-dev] [PATCH 12/18] i965: Drop use of intel_region from miptrees.

Chad Versace chad.versace at linux.intel.com
Thu May 1 10:35:29 PDT 2014


On Tue, Apr 29, 2014 at 04:34:37PM -0700, Eric Anholt wrote:
> Note: region->width used to reflect the total_width/height padding of
> separate stencil, and mt->total_width doesn't.

The note scares me. It tells me the patch has a known, potential bug
regarding stencil buffers...  but after some digging I convinced myself
that there's no stencil bug.

Please provide some assurance in the commit message that there is no
bug. I think it's sufficient to explain that, in the patch, each
substitution of region->width with rb->Width is safe because the
renderbuffer is never a stencil buffer nor multisampled in those
functions.

Add some assurance to the commit message and this patch is
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>


More information about the mesa-dev mailing list