[Mesa-dev] [PATCH] i965: Set miptree target field when creating from a BO.

[Jordan Justen]

Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>

On Thu, May 1, 2014 at 11:48 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> Prior to commit 8435b60a3577d2d905eae189cd7e770500177e99, the region
> equivalent of this function called intel_miptree_create_layout, which
> set mt->target to target.  With that commit, it no longer copied target.
>
> Piglit's ext_image_dma_buf_import-sample_[xa]rgb8888 tests would then
> hit an assertion failure, where image->TexObject->Target was
> GL_TEXTURE_EXTERNAL_OES, and mt->target was GL_TEXTURE_2D.
>
> Copying the target fixes this assertion failure.
>
> Cc: Eric Anholt <eric at anholt.net>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/drivers/dri/i965/intel_tex_image.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_tex_image.c b/src/mesa/drivers/dri/i965/intel_tex_image.c
> index fbb799b..4eb024f 100644
> --- a/src/mesa/drivers/dri/i965/intel_tex_image.c
> +++ b/src/mesa/drivers/dri/i965/intel_tex_image.c
> @@ -234,6 +234,7 @@ intel_set_texture_image_bo(struct gl_context *ctx,
>                                                   0, width, height, pitch);
>     if (intel_image->mt == NULL)
>         return;
> +   intel_image->mt->target = target;
>     intel_image->mt->total_width = width;
>     intel_image->mt->total_height = height;
>     intel_image->mt->level[0].slice[0].x_offset = tile_x;
> --
> 1.9.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev