[Mesa-dev] [PATCH 00/15] Klocwork patches again

Ian Romanick idr at freedesktop.org
Fri May 2 12:05:20 PDT 2014


I just pushed the first 3 patches (the ones with Reviewed-bys).  I had
to modify patch 3 to avoid a MSVC build break.  We should be able to get
most or all of the others for 10.2-rc2.

On 04/27/2014 01:04 PM, Juha-Pekka Heikkila wrote:
> Most of these were earlier on the list but they seem to have vanished
> to void already. This set pass piglit quick set on my ivybridge without
> regressions.
> 
> Patch 15 (i965: Avoid null access in intelMakeCurrent()) I'm was a bit
> iffy if its the same behavior which I replaced.
> 
> In patch 14 (mesa/drivers: Add extra null check in blitframebuffer_texture())
> GetDrawableAttribute may send GLXBadDrawable if <draw> is not bound 
> to thread's context. Should GLXBadDrawable be sent also if 
> GetGLXDRIDrawable(dpy, drawable) return NULL because it mean drawable 
> is not associated with a direct-rendering context. Now just return 0.
> 
> /Juha-Pekka
> 
> Ian Romanick (1):
>   mesa: Add _mesa_error_no_memory for logging out-of-memory messages
> 
> Juha-Pekka Heikkila (14):
>   mesa: add missing null checks in _tnl_register_fastpath()
>   mesa: add extra null checks in vbo_rebase_prims()
>   mesa: In emit_texenv() type mismatch was forced with typecast
>   mesa: Add missing null checks into prog_hash_table.c
>   glsl: add missing null check in tfeedback_decl::init()
>   mesa: add missing null check in _mesa_NewHashTable()
>   i965: check malloc return value in intel_resolve_map_set()
>   mesa: add null checks in symbol_table.c
>   glsl: Add null check in loop_analysis.cpp
>   glsl: check _mesa_hash_table_create return value in
>     link_uniform_blocks
>   i965/fs: Check variable_storage return value in fs_visitor::visit
>   glx: Added missing null check in GetDrawableAttribute()
>   mesa/drivers: Add extra null check in blitframebuffer_texture()
>   i965: Avoid null access in intelMakeCurrent()
> 
>  src/glsl/Makefile.am                          | 13 ++++++++----
>  src/glsl/link_uniform_blocks.cpp              |  5 +++++
>  src/glsl/link_varyings.cpp                    |  5 +++++
>  src/glsl/loop_analysis.cpp                    |  6 ++++--
>  src/glsl/main.cpp                             |  6 ++++++
>  src/glsl/tests/common.c                       | 30 +++++++++++++++++++++++++++
>  src/glx/glx_pbuffer.c                         |  4 ++++
>  src/mesa/drivers/common/meta_blit.c           |  7 +++++++
>  src/mesa/drivers/dri/i965/brw_context.c       | 10 ++++++---
>  src/mesa/drivers/dri/i965/brw_fs_visitor.cpp  |  6 ++++++
>  src/mesa/drivers/dri/i965/intel_resolve_map.c |  7 +++++++
>  src/mesa/main/errors.c                        |  6 ++++++
>  src/mesa/main/errors.h                        |  3 +++
>  src/mesa/main/ff_fragment_shader.cpp          | 17 ++++++++-------
>  src/mesa/main/hash.c                          | 10 +++++++++
>  src/mesa/program/prog_hash_table.c            |  8 +++++++
>  src/mesa/program/symbol_table.c               | 30 +++++++++++++++++++++++++++
>  src/mesa/tnl/t_vertex.c                       | 14 +++++++++++--
>  src/mesa/vbo/vbo_rebase.c                     | 19 +++++++++++++++++
>  19 files changed, 187 insertions(+), 19 deletions(-)
>  create mode 100644 src/glsl/tests/common.c
> 



More information about the mesa-dev mailing list