[Mesa-dev] recent build breakage w.r.t. dri3

[Brian Paul]

On 05/02/2014 04:23 PM, Emil Velikov wrote:
> On 02/05/14 23:01, Armin K. wrote:
>> On 05/02/2014 11:51 PM, Brian Paul wrote:
>>> I don't have time to investigate right now, but a recent Mesa commit
>>> seems to have broke some of our automated builds on Linux:
>>>
>>> With SCONS:
>>>
>>> scons: done reading SConscript files.
>>> scons: Building targets ...
>>>    Compiling src/gallium/state_trackers/egl/x11/x11_screen.c ...
>>>    Compiling src/gallium/state_trackers/egl/x11/dri2.c ...
>>>    Compiling src/glx/dri2.c ...
>>>    Compiling src/glx/dri2_glx.c ...
>>>    Compiling src/glx/dri2_query_renderer.c ...
>>> In file included from src/glx/dri2_query_renderer.c:31:0:
>>> src/glx/dri3_priv.h:58:22: fatal error: xcb/dri3.h: No such file or
>>> directory
>>>   #include <xcb/dri3.h>
>>>                        ^
>>> compilation terminated.
>>>    Compiling src/glx/dri_glx.c ...
>>> scons: *** [build/linux-x86_64-checked/glx/dri2_query_renderer.os] Error 1
>>> scons: building terminated because of errors.
>>>
>>>
>>> With make:
>>>
>>>    CC       glxhash.lo
>>>    CC       dri2_glx.lo
>>>    CC       dri2.lo
>>>    CC       dri2_query_renderer.lo
>>>    CC       applegl_glx.lo
>>> In file included from dri2_query_renderer.c:31:0:
>>> dri3_priv.h:58:22: fatal error: xcb/dri3.h: No such file or directory
>>>   #include <xcb/dri3.h>
>>>                        ^
>>> compilation terminated.
>>> make[3]: *** [dri2_query_renderer.lo] Error 1
>>> make[3]: Leaving directory
>>> `/var/lib/hudson/jobs/mesa-ubuntu64-make/workspace/src/glx'
>>> make[2]: *** [all-recursive] Error 1
>>> make[2]: Leaving directory
>>> `/var/lib/hudson/jobs/mesa-ubuntu64-make/workspace/src/glx'
>>> make[1]: *** [all-recursive] Error 1
>>> make[1]: Leaving directory
>>> `/var/lib/hudson/jobs/mesa-ubuntu64-make/workspace/src'
>>> make: *** [all-recursive] Error 1
>>>
>>> It would be great if someone could check on this.
>>>
>>> -Brian
>>> _______________________________________________
>>> mesa-dev mailing list
>>> mesa-dev at lists.freedesktop.org
>>> https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.org/mailman/listinfo/mesa-dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=lGQMzzTgII0I7jefp2FHq7WtZ%2BTLs8wadB%2BiIj9xpBY%3D%0A&m=3Wv2C6h%2FGq%2BW%2Fe5ajUPMNrTehyoUJpOMV%2BDnavdvQIk%3D%0A&s=d6c9417208d65c58d8137015a63070b8671838677cb6e0c72cd3448f57d76f60
>>
>> Does the attached patch fix the build for you?
>>
> Sorry for the breakage gents.
>
> The attached patch does resolve the problem on my system, and is obviously the
> right thing to do. Thanks Armin.
>
> I've slapped the following two and pushed to master.

Yup, that fixed it.  Thanks!

-Brian