[Mesa-dev] [Bug 78258] make check link_varyings.gl_ClipDistance failure

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed May 7 09:51:51 PDT 2014


https://bugs.freedesktop.org/show_bug.cgi?id=78258

Ian Romanick <idr at freedesktop.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Ian Romanick <idr at freedesktop.org> ---
Fixed on master by the commit below.  This patch has also been cherry picked to
the 10.2 branch.

commit f7bf37cb13ff4e727d640a3bd02980aba0c0b4ce
Author: Ian Romanick <ian.d.romanick at intel.com>
Date:   Mon May 5 10:39:26 2014 -0700

    linker: Fix consumer_inputs_with_locations indexing

    In an earlier incarnation of populate_consumer_input_sets and
    get_matching_input, the consumer_inputs_with_locations array was indexed
    using the user-specified location.  In that version, only user-defined
    varyings were included in the array.

    In the current incarnation, the Mesa location is used to index the
    array, and built-in varyings are included.

    This change fixes the unit test to exepect gl_ClipDistance in the array,
    and it resizes the arrays to actually be big enough.  It's just dumb
    luck that the existing piglit tests use small enough locations to not
    stomp the stack. :(

    Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78258
    Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
    Cc: "10.2" <mesa-stable at lists.freedesktop.org>
    Cc: Vinson Lee <vlee at freedesktop.org>

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140507/abea0887/attachment.html>


More information about the mesa-dev mailing list