[Mesa-dev] [PATCH 1/2] pipe-loader: Don't destroy the winsys in the sw loader

[Emil Velikov]

On 09/05/14 02:17, Tom Stellard wrote:
> The screen takes ownership of the winsys, and is responsible for
> destroying it.  Users of pipe-loader should make sure they destory
> and  screens they've created to avoid memory leaks.
> 
I was under false impression that our current sw screens do not destroy the
winsys.

Cc: "10.2" <mesa-stable at lists.freedesktop.org>
Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

> This fixes a crash in clover introduced by
> ce6c17c0833032e91a2d1b34f9eb80c738a854a2 where the pipe-loader was
> destroying the winsys while a screen was still using it.
> ---
>  src/gallium/auxiliary/pipe-loader/pipe_loader_sw.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/src/gallium/auxiliary/pipe-loader/pipe_loader_sw.c b/src/gallium/auxiliary/pipe-loader/pipe_loader_sw.c
> index 08d4353..fa317f2 100644
> --- a/src/gallium/auxiliary/pipe-loader/pipe_loader_sw.c
> +++ b/src/gallium/auxiliary/pipe-loader/pipe_loader_sw.c
> @@ -145,9 +145,6 @@ pipe_loader_sw_release(struct pipe_loader_device **dev)
>  {
>     struct pipe_loader_sw_device *sdev = pipe_loader_sw_device(*dev);
>  
> -   if (sdev->ws && sdev->ws->destroy)
> -      sdev->ws->destroy(sdev->ws);
> -
>     if (sdev->lib)
>        util_dl_close(sdev->lib);
>  
>