[Mesa-dev] [PATCH] ralloc: Omit detailed license information about talloc.

[Jose Fonseca]

----- Original Message -----
> On Fri, May 9, 2014 at 2:55 AM,  <jfonseca at vmware.com> wrote:
> > From: José Fonseca <jfonseca at vmware.com>
> >
> > That information misleads source code auditing tools to think that
> > ralloc itself is released under LGPL v3.
> >
> > Instead, simply state talloc is not licensed under a permissive license.
> > ---
> >  src/glsl/ralloc.h | 7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/src/glsl/ralloc.h b/src/glsl/ralloc.h
> > index 4581a7a..70f7d9c 100644
> > --- a/src/glsl/ralloc.h
> > +++ b/src/glsl/ralloc.h
> > @@ -38,10 +38,9 @@
> >   * Tridgell's talloc, but ralloc is an independent implementation
> >   * released under the MIT license and tuned for Mesa.
> >   *
> > - * The talloc implementation is available under the GNU Lesser
> > - * General Public License (GNU LGPL), version 3 or later. It is
> > - * more sophisticated than ralloc in that it includes reference
> > - * counting and debugging features. See:
> > https://urldefense.proofpoint.com/v1/url?u=http://talloc.samba.org/&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=NMr9uy2iTjWVixC0wOcYCWEIYhfo80qKwRgdodpoDzA%3D%0A&m=W9QOIrhCEXJz3yIQbKcCXWeb39YRUJRWizIYkimspSE%3D%0A&s=a97e9dd737954d1433e70ee76d13fdc7c1f433e837da4f3c217138445a70320f
> > + * The talloc implementation is not available under a permissive
> > + * license. It is more sophisticated than ralloc in that it includes
> > + * reference counting and debugging features. See:
> > https://urldefense.proofpoint.com/v1/url?u=http://talloc.samba.org/&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=NMr9uy2iTjWVixC0wOcYCWEIYhfo80qKwRgdodpoDzA%3D%0A&m=W9QOIrhCEXJz3yIQbKcCXWeb39YRUJRWizIYkimspSE%3D%0A&s=a97e9dd737954d1433e70ee76d13fdc7c1f433e837da4f3c217138445a70320f
> 
> What about this instead?
> 
> "The talloc implementation is available under a different open source
> license.

I'm not sure in what way it is better.  The reason talloc was inadequate was not only because it was in a different license but because it was a copyleft (non-permissive) license.  (E.g., LLVM has a different license from Mesa, but nobody went out its way to replace it.) 

That said, I don't care either way.  Provided it doesn't have " GNU Lesser General Public License" nor "LPGL" it should be fine.   (I also though of saying "copyleft" instead of non-permissive, but again, I worry it might cause more confusion.)

We could also remove this sentence all together.

Jose


> It is more sophisticated than ralloc in that it includes
> reference counting and debugging features. See:
> https://urldefense.proofpoint.com/v1/url?u=http://talloc.samba.org/&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=NMr9uy2iTjWVixC0wOcYCWEIYhfo80qKwRgdodpoDzA%3D%0A&m=W9QOIrhCEXJz3yIQbKcCXWeb39YRUJRWizIYkimspSE%3D%0A&s=a97e9dd737954d1433e70ee76d13fdc7c1f433e837da4f3c217138445a70320f"
> 
> -Jordan
> 
> >   */
> >
> >  #ifndef RALLOC_H
> > --
> > 1.9.1
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.org/mailman/listinfo/mesa-dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=NMr9uy2iTjWVixC0wOcYCWEIYhfo80qKwRgdodpoDzA%3D%0A&m=W9QOIrhCEXJz3yIQbKcCXWeb39YRUJRWizIYkimspSE%3D%0A&s=e68a5b29bd3b5c9d5a4d11685f95f0a1bac85f0e038b397051d0bc8b1aaee2ff
>