[Mesa-dev] [PATCH 1/3] gallium: add bit to pipe_blit_info to leave current query enabled

[Marek Olšák]

Alright: boolean render_condition_enable; :)

Marek

On Sun, May 11, 2014 at 1:32 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> It's all the same to me... let me know which you prefer, and I can
> send out a v2.
>
> On Sat, May 10, 2014 at 7:30 PM, Marek Olšák <maraeo at gmail.com> wrote:
>> Hi Ilia,
>>
>> I'd call it:
>>
>>   boolean conditional_rendering;
>> or
>>   boolean render_condition_enable;
>> or
>>   boolean use_render_condition;
>>
>> Marek
>>
>> On Sat, May 10, 2014 at 7:25 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>>> Previously the implication was that queries should be disabled during
>>> blits. However glBlitFramebuffer() is supposed to obey the current
>>> query, and this new bit will indicate that to the driver.
>>>
>>> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
>>> Cc: "10.2" <mesa-stable at lists.freedesktop.org>
>>> ---
>>>  src/gallium/include/pipe/p_state.h | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/src/gallium/include/pipe/p_state.h b/src/gallium/include/pipe/p_state.h
>>> index a41c53d..d495159 100644
>>> --- a/src/gallium/include/pipe/p_state.h
>>> +++ b/src/gallium/include/pipe/p_state.h
>>> @@ -591,6 +591,8 @@ struct pipe_blit_info
>>>
>>>     boolean scissor_enable;
>>>     struct pipe_scissor_state scissor;
>>> +
>>> +   boolean query_enable; /**< whether to leave current query enabled */
>>>  };
>>>
>>>
>>> --
>>> 1.8.5.5
>>>
>>> _______________________________________________
>>> mesa-dev mailing list
>>> mesa-dev at lists.freedesktop.org
>>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev