[Mesa-dev] [PATCH 2/8] radeon: add basic register setup for per-sample shading

[Michel Dänzer]

On 07.05.2014 23:00, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>
> 
> Only for Cayman, SI, CIK.

[...]

> diff --git a/src/gallium/drivers/radeon/r600d_common.h b/src/gallium/drivers/radeon/r600d_common.h
> index 1172af0..fa6131f 100644
> --- a/src/gallium/drivers/radeon/r600d_common.h
> +++ b/src/gallium/drivers/radeon/r600d_common.h
> @@ -160,6 +160,9 @@
>  #define   G_028B98_STREAM_3_BUFFER_EN(x)                              (((x) >> 12) & 0x0F)
>  #define   C_028B98_STREAM_3_BUFFER_EN                                 0xFFFF0FFF
>  
> +#define EG_R_028A4C_PA_SC_MODE_CNTL_1                0x028A4C
> +#define   EG_S_028A4C_PS_ITER_SAMPLE(x)                 (((x) & 0x1) << 16)

Shouldn't this be CM_* instead of EG_*?


Other than that, the series looks good to me. Not sure what could be
wrong with the sample mask export. :( My guess would be it requires some
other hardware state to match, but I'm not sure offhand what or how.


-- 
Earthling Michel Dänzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer