[Mesa-dev] [Bug 77288] [swrast] piglit glean glsl1 regression

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue May 13 13:41:01 PDT 2014


https://bugs.freedesktop.org/show_bug.cgi?id=77288

--- Comment #2 from Brian Paul <brianp at vmware.com> ---
This patch silences the assertion, but I'm really not sure if it's the right
thing to do.


--- a/src/mesa/program/ir_to_mesa.cpp
+++ b/src/mesa/program/ir_to_mesa.cpp
@@ -1797,7 +1797,8 @@ ir_to_mesa_visitor::visit(ir_assignment *ir)
       int first_enabled_chan = 0;
       int rhs_chan = 0;

-      assert(ir->lhs->type->is_vector());
+      assert(ir->lhs->type->is_vector() ||
+             ir->lhs->type->is_matrix());
       l.writemask = ir->write_mask;

       for (int i = 0; i < 4; i++) {


The corresponding code in the src/mesa/state_tracker/st_glsl_to_tgsi.cpp has no
type assertions.  So maybe we should just remove the assert()?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140513/c3ebacc2/attachment.html>


More information about the mesa-dev mailing list