[Mesa-dev] [PATCH] st/mesa: don't disallow indirect addressing of temporaries

[Michel Dänzer]

On 14.05.2014 06:45, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>
> 
> It works just fine.
> 
> This fixes a crash in:
>   piglit/spec/glsl-1.20/execution/fs-const-array-of-struct-of-array
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78666
> 
> Cc: 10.2 10.1 mesa-stable at lists.freedesktop.org
> ---
>  src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
> index bdee1f4..eab7d8a 100644
> --- a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
> +++ b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
> @@ -4475,7 +4475,6 @@ translate_src(struct st_translate *t, const st_src_reg *src_reg)
>        src = ureg_negate(src);
>  
>     if (src_reg->reladdr != NULL) {
> -      assert(src_reg->file != PROGRAM_TEMPORARY);
>        src = ureg_src_indirect(src, ureg_src(t->address[0]));
>     }
>  
> 

Tested-by: Michel Dänzer <michel.daenzer at amd.com>

Christian added this assertion in commit
3f67251e3d0ce61a0e7fc16de91de6fb49cad768, he should probably take a look.


-- 
Earthling Michel Dänzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer