[Mesa-dev] [PATCH] i965: Remove blorp unit tests.

[Kenneth Graunke]

On 05/14/2014 03:19 PM, Matt Turner wrote:
> They've served their purpose (in transitioning blorp to using
> fs_generator) and now they just necessitate large amounts of manual
> labor to regenerate if the disassembler changes.
> 
> Cc: Topi Pohjolainen <topi.pohjolainen at intel.com>
> ---
> Deleted file diff removed.
> 
>  src/mesa/drivers/dri/i965/.gitignore               |    1 -
>  src/mesa/drivers/dri/i965/Makefile.am              |    7 +-
>  .../drivers/dri/i965/test_blorp_blit_eu_gen.cpp    | 1092 --------------------
>  3 files changed, 1 insertion(+), 1099 deletions(-)
>  delete mode 100644 src/mesa/drivers/dri/i965/test_blorp_blit_eu_gen.cpp
> 
> diff --git a/src/mesa/drivers/dri/i965/.gitignore b/src/mesa/drivers/dri/i965/.gitignore
> index 3cf4ba0..cb66728 100644
> --- a/src/mesa/drivers/dri/i965/.gitignore
> +++ b/src/mesa/drivers/dri/i965/.gitignore
> @@ -2,4 +2,3 @@ i965_symbols_test
>  test_eu_compact
>  test_vec4_copy_propagation
>  test_vec4_register_coalesce
> -test_blorp_blit_eu_gen
> diff --git a/src/mesa/drivers/dri/i965/Makefile.am b/src/mesa/drivers/dri/i965/Makefile.am
> index 7ab376c..5809dc6 100644
> --- a/src/mesa/drivers/dri/i965/Makefile.am
> +++ b/src/mesa/drivers/dri/i965/Makefile.am
> @@ -56,8 +56,7 @@ TEST_LIBS = \
>  TESTS = \
>          test_eu_compact \
>          test_vec4_copy_propagation \
> -        test_vec4_register_coalesce \
> -        test_blorp_blit_eu_gen
> +        test_vec4_register_coalesce
>  
>  check_PROGRAMS = $(TESTS)
>  
> @@ -77,7 +76,3 @@ test_eu_compact_SOURCES = \
>  	test_eu_compact.c
>  nodist_EXTRA_test_eu_compact_SOURCES = dummy.cpp
>  test_eu_compact_LDADD = $(TEST_LIBS)
> -
> -test_blorp_blit_eu_gen_SOURCES = \
> -        test_blorp_blit_eu_gen.cpp
> -test_blorp_blit_eu_gen_LDADD = $(TEST_LIBS)
> 

Sounds good to me.  They were useful at the time, but I think the
ongoing burden of maintaining them is not worth it.

Acked-by: Kenneth Graunke <kenneth at whitecape.org>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140514/5c4fab70/attachment.sig>