[Mesa-dev] [Mesa-stable] [PATCH 2/4] meta: Drop unnecessary early returns in _mesa_meta_BlitFramebuffer.

[Courtney Goeltzenleuchter]

Looks good.

Reviewed-by: Courtney Goeltzenleuchter <courtney at lunarg.com>


On Mon, May 19, 2014 at 12:12 AM, Kenneth Graunke <kenneth at whitecape.org>wrote:

> These aren't necessary - all of the following code is predicated on mask
> being non-zero, so no code will get executed anyway.
>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> Cc: "10.2" <mesa-stable at lists.freedesktop.org>
> ---
>  src/mesa/drivers/common/meta_blit.c | 8 --------
>  1 file changed, 8 deletions(-)
>
> diff --git a/src/mesa/drivers/common/meta_blit.c
> b/src/mesa/drivers/common/meta_blit.c
> index beb1ea5..bd6118b 100644
> --- a/src/mesa/drivers/common/meta_blit.c
> +++ b/src/mesa/drivers/common/meta_blit.c
> @@ -705,10 +705,6 @@ _mesa_meta_BlitFramebuffer(struct gl_context *ctx,
>                                    filter, dstFlipX, dstFlipY,
>                                    use_glsl_version, false)) {
>           mask &= ~GL_COLOR_BUFFER_BIT;
> -         if (mask == 0x0) {
> -            _mesa_meta_end(ctx);
> -            return;
> -         }
>        }
>     }
>
> @@ -718,10 +714,6 @@ _mesa_meta_BlitFramebuffer(struct gl_context *ctx,
>                                    filter, dstFlipX, dstFlipY,
>                                    use_glsl_version, true)) {
>           mask &= ~GL_DEPTH_BUFFER_BIT;
> -         if (mask == 0x0) {
> -            _mesa_meta_end(ctx);
> -            return;
> -         }
>        }
>     }
>
> --
> 1.9.2
>
> _______________________________________________
> mesa-stable mailing list
> mesa-stable at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-stable
>



-- 
Courtney Goeltzenleuchter
LunarG
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140519/0709ed44/attachment.html>