[Mesa-dev] [PATCH] loader: allow alternative methods for PCI identification.

[Emil Velikov]

On 20/05/14 18:04, Gary Wong wrote:
> On Tue, May 20, 2014 at 12:07:15AM +0100, Emil Velikov wrote:
>> As you can notice I'm not a huge fan of adding yet another way of
>> retrieving the device/driver name although I would not object if
>> you're willing to split this patch a bit, have the option off by
>> default and fix bugs if/when they pop up :)
> 
> Sure, I'm happy to disable the autoconf variable by default, and can
> sign up for bug fix duty.
> 
Great :)

> Do you have some way to "split this patch a bit" in mind?  When I have
> a chance I can split it in two commits (one adding the generic
> loader_get_pci_id_for_fd and loader_get_device_name_for_fd functions
> but keeping the current behaviour; the other inserting the
> disabled-by-default sysfs hooks into the generic functions), but
> please let me know if you'd prefer a different approach.
> 
As long as the re-factoring and the new sysfs code are separate I have no real
objections exactly how you should cut it.

Cheers,
Emil

> Thanks,
> Gary.
>