[Mesa-dev] [PATCH] i965: Ask the VBO module to actually use VBOs.

[Kenneth Graunke]

On 05/20/2014 11:00 AM, Eric Anholt wrote:
> Note that this covers the Begin/End rendering path, but not user vertex
> arrays (so we can't drop copy_array_to_vbo_array() code).  Improves
> performance of isosurf GLVERTEX|TRIANGLES by 16.7506% +/- 4.98934%
> (n=20). No difference on openarena (n=10), which was why this was reverted
> back in cbde2765804a4fc62bcf092230a01376aedbf2cd.
> ---
>  src/mesa/drivers/dri/i965/brw_context.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c
> index 17ae685..39dd582 100644
> --- a/src/mesa/drivers/dri/i965/brw_context.c
> +++ b/src/mesa/drivers/dri/i965/brw_context.c
> @@ -781,6 +781,9 @@ brwCreateContext(gl_api api,
>        brw_init_performance_monitors(brw);
>     }
>  
> +   vbo_use_buffer_objects(ctx);
> +   vbo_always_unmap_buffers(ctx);
> +
>     return true;
>  }

Hah!  You finally found the benchmark.  I've had this patch sitting
around for ages, and never observed any difference.  Nice.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140520/b3434003/attachment.sig>