[Mesa-dev] [PATCH 4/4] targets/libgl-xlib: hide all the exported symbol mayhem

[Emil Velikov]

Similar to 3/4 I will the mangled gl symbols to the global list.
   mgl*;

Other than that, an acked-by would be appreciated :)

-Emil

On 09/05/14 18:15, Emil Velikov wrote:
> Ping
> 
> Btw the TODO list here was for my personal reference, I'll change/nuke it
> before pushing.
> 
> Cheers,
> Emil
> 
> On 02/05/14 22:02, Emil Velikov wrote:
>> TODO:
>>  - properly cleanup all the _glapi* symbols
>>  - XMesa*
>>  -- no sign of the header even being distributed
>>  -- mesa-demos uses it to the point that the relevant code is not compiled
>>  -- the classic driver (x11) exibits the same issues
>>
>> Brian,
>>
>> Do you know of any users of the XMesa* functions outside of mesa-demos ?
>> AFAICS we should be safe with dropping PUBLIC although I may have missed
>> something. As a follow up someone can cleanup all the mesa-demos code :)
>>
>> Cc: Brian Paul <brianp at vmware.com>
>> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
>> ---
>>  src/gallium/targets/libgl-xlib/Makefile.am    | 1 +
>>  src/gallium/targets/libgl-xlib/libgl-xlib.sym | 6 ++++++
>>  2 files changed, 7 insertions(+)
>>  create mode 100644 src/gallium/targets/libgl-xlib/libgl-xlib.sym
>>
>> diff --git a/src/gallium/targets/libgl-xlib/Makefile.am b/src/gallium/targets/libgl-xlib/Makefile.am
>> index 4ee364e..3718243 100644
>> --- a/src/gallium/targets/libgl-xlib/Makefile.am
>> +++ b/src/gallium/targets/libgl-xlib/Makefile.am
>> @@ -47,6 +47,7 @@ libGL_la_SOURCES = xlib.c
>>  libGL_la_LDFLAGS = \
>>  	-no-undefined \
>>  	-version-number $(GL_MAJOR):$(GL_MINOR):$(GL_TINY) \
>> +	-Wl,--version-script=$(top_srcdir)/src/gallium/targets/libgl-xlib/libgl-xlib.sym \
>>  	$(GC_SECTIONS) \
>>  	$(LD_NO_UNDEFINED)
>>  
>> diff --git a/src/gallium/targets/libgl-xlib/libgl-xlib.sym b/src/gallium/targets/libgl-xlib/libgl-xlib.sym
>> new file mode 100644
>> index 0000000..d6cd23d
>> --- /dev/null
>> +++ b/src/gallium/targets/libgl-xlib/libgl-xlib.sym
>> @@ -0,0 +1,6 @@
>> +{
>> +	global:
>> +		gl*;
>> +	local:
>> +		*;
>> +};
>>
>