[Mesa-dev] [PATCH 05/10] i965/sf: Drop useless push/pop state from flag register mashing code.

Kenneth Graunke kenneth at whitecape.org
Sun May 25 01:08:51 PDT 2014


There's no point in pushing and popping the default state; the code
between the two stack operations doesn't alter anything.

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
---
 src/mesa/drivers/dri/i965/brw_eu.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_eu.c b/src/mesa/drivers/dri/i965/brw_eu.c
index c4ded5a..075cc53 100644
--- a/src/mesa/drivers/dri/i965/brw_eu.c
+++ b/src/mesa/drivers/dri/i965/brw_eu.c
@@ -98,10 +98,8 @@ void brw_set_predicate_control_flag_value( struct brw_compile *p, unsigned value
 
    if (value != 0xff) {
       if (value != p->flag_value) {
-	 brw_push_insn_state(p);
 	 brw_MOV(p, brw_flag_reg(0, 0), brw_imm_uw(value));
 	 p->flag_value = value;
-	 brw_pop_insn_state(p);
       }
 
       p->current->header.predicate_control = BRW_PREDICATE_NORMAL;
-- 
1.9.2



More information about the mesa-dev mailing list