[Mesa-dev] [PATCH 08/16] mesa: Remove stale comment (and fix grammar in the remainder).

Eric Anholt eric at anholt.net
Wed May 28 11:37:39 PDT 2014


_mesa_add_state_reference() already checks to see if you've already got
that state referenced.
---
 src/mesa/program/programopt.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/src/mesa/program/programopt.c b/src/mesa/program/programopt.c
index 39a83b4..bcc0b75 100644
--- a/src/mesa/program/programopt.c
+++ b/src/mesa/program/programopt.c
@@ -53,10 +53,7 @@ _mesa_insert_mvp_dp4_code(struct gl_context *ctx, struct gl_vertex_program *vpro
    const GLuint newLen = origLen + 4;
    GLuint i;
 
-   /*
-    * Setup state references for the modelview/projection matrix.
-    * XXX we should check if these state vars are already declared.
-    */
+   /* Set up state references for the modelview/projection matrix. */
    static const gl_state_index mvpState[4][STATE_LENGTH] = {
       { STATE_MVP_MATRIX, 0, 0, 0, 0 },  /* state.matrix.mvp.row[0] */
       { STATE_MVP_MATRIX, 0, 1, 1, 0 },  /* state.matrix.mvp.row[1] */
@@ -120,10 +117,7 @@ _mesa_insert_mvp_mad_code(struct gl_context *ctx, struct gl_vertex_program *vpro
    GLuint hposTemp;
    GLuint i;
 
-   /*
-    * Setup state references for the modelview/projection matrix.
-    * XXX we should check if these state vars are already declared.
-    */
+   /* Set up state references for the modelview/projection matrix. */
    static const gl_state_index mvpState[4][STATE_LENGTH] = {
       { STATE_MVP_MATRIX, 0, 0, 0, STATE_MATRIX_TRANSPOSE },
       { STATE_MVP_MATRIX, 0, 1, 1, STATE_MATRIX_TRANSPOSE },
-- 
2.0.0.rc2



More information about the mesa-dev mailing list