[Mesa-dev] [PATCH v2 3/4] glsl/tests: call create_test_cases.py in optimization-test

[Kenneth Graunke]

On 05/28/2014 01:17 PM, Matt Turner wrote:
> On Wed, May 28, 2014 at 1:09 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
>> On 05/27/2014 06:23 PM, Connor Abbott wrote:
>>> This way, when someone modifies create_test_cases.py and forgets to
>>> commit their changes again, people will notice.
>>>
>>> v2: make sure we parse the right directories and check for existance the
>>> right way.
>>>
>>> Signed-off-by: Connor Abbott <cwabbott0 at gmail.com>
>>> ---
>>>  src/glsl/tests/optimization-test | 8 ++++++++
>>>  1 file changed, 8 insertions(+)
>>>
>>> diff --git a/src/glsl/tests/optimization-test b/src/glsl/tests/optimization-test
>>> index 8ca7776..bf15153 100755
>>> --- a/src/glsl/tests/optimization-test
>>> +++ b/src/glsl/tests/optimization-test
>>> @@ -9,6 +9,14 @@ fi
>>>  total=0
>>>  pass=0
>>>
>>> +echo "======       Generating tests      ======"
>>> +for dir in tests/*/; do
>>> +    if [ -e "${dir}create_test_cases.py" ]; then
>>> +        cd $dir; python create_test_cases.py; cd ..
>>
>> You want to use $PYTHON2 rather than "python" directly.  Otherwise, this
>> will break on distros like Arch which (against the Python Foundation's
>> recommendation), install Python 3 as /usr/bin/python.
>>
>> With that fixed, this series is:
>> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
>>
>> It sounds like Matt may have some comments as well, so I'll hold off on
>> pushing these right away...
> 
> Nah, they're find with me. Nothing I can't change later if needed. The series is
> 
> Reviewed-by: Matt Turner <mattst88 at gmail.com>

In that case...I fixed up the one $PYTHON2 thing and pushed them.

Thanks for doing this, Connor!


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140528/dff2b0ec/attachment-0001.sig>