[Mesa-dev] [PATCH V2 11/11] Radeonsi: Use dma_copy when possible for si_blit.

[Marek Olšák]

On Thu, May 29, 2014 at 8:15 PM, Axel Davy <axel.davy at ens.fr> wrote:
> On 29/05/2014 13:37, Marek Olšák wrote :
>
>> Hi Axel,
>>
>> Could you please describe what "GPU offloading" means?
>
> It's using a different GPU to render and to display.
>
> Basically the gpu offloading support added by the patches is similar to
> enduro.
>
>> Some checks can be modified to:
>>
>> info->src.box.width > 0 &&
>> info->src.box.height > 0 &&
>> ... resource->nr_samples <= 1
>
> We discussed on irc about nr_samples, and it was not clear what the
> behaviour should be when it equals 1,
> thus the decision to only allow 0 for this path.
> I agree for the width and height.

I guess those people on IRC were just guessing. I can assure you that
0 and 1 both mean 1 sample. All of Mesa code uses "nr_samples <= 1"
and "nr_samples > 1" expressions when checking for MSAA resources.

Marek