[Mesa-dev] [PATCH 0/2] Klocwork patches

[Pohjolainen, Topi]

On Fri, May 30, 2014 at 01:54:46PM +0300, Juha-Pekka Heikkila wrote:
> These pass piglit quick set on my Ivybridge.

The stencil meta path is not in use on ivb - you would need bdw for that.

> 
> For patch number 2 it bring the error all the way to set_read_rb_tex_image()
> which is "static void" function. Was pondering if it be changed to
> "static bool" to be able to carry the error further? (it is anyhow marked
> into the context at this point) This change would probably cause some
> restucturing in brw_meta_stencil_blit()
> 
> /Juha-Pekka
> 
> Juha-Pekka Heikkila (2):
>   i965/fs: Add missing null checks in fs_generator::generate_assembly()
>   i965: in set_read_rb_tex_image() check
>     _mesa_meta_bind_rb_as_tex_image() did succeed
> 
>  src/mesa/drivers/common/meta_blit.c               | 10 +++++++++-
>  src/mesa/drivers/dri/i965/brw_fs_generator.cpp    |  4 ++--
>  src/mesa/drivers/dri/i965/brw_meta_stencil_blit.c |  6 ++++--
>  3 files changed, 15 insertions(+), 5 deletions(-)
> 
> -- 
> 1.8.1.2
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev