[Mesa-dev] [PATCH 09/21] glsl: Set ir_instruction::ir_type in the base class constructor

[Kenneth Graunke]

On Tuesday, May 27, 2014 07:49:04 PM Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> This has the added perk that if you forget to set ir_type in the
> constructor of a new subclass (or a new constructor of an existing
> subclass) the compiler will tell you... instead of relying on
> ir_validate or similar run-time detection.
> 
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
>  src/glsl/ir.cpp | 65
> ++++++++++++++++++++++++++------------------------------- src/glsl/ir.h   |
> 46 +++++++++++++++++++++++-----------------
>  2 files changed, 57 insertions(+), 54 deletions(-)


This seems reasonable to me.  Patch 9 is:

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140530/4d3887c5/attachment.sig>