[Mesa-dev] [PATCH] i965/disasm: Disassemble tdr and tm registers properly.

Kenneth Graunke kenneth at whitecape.org
Mon Nov 3 15:43:28 PST 2014


On Monday, November 03, 2014 11:00:04 AM Matt Turner wrote:
> ---
>  src/mesa/drivers/dri/i965/brw_disasm.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_disasm.c 
b/src/mesa/drivers/dri/i965/brw_disasm.c
> index 53ec767..a0f6d57 100644
> --- a/src/mesa/drivers/dri/i965/brw_disasm.c
> +++ b/src/mesa/drivers/dri/i965/brw_disasm.c
> @@ -681,6 +681,12 @@ reg(FILE *file, unsigned _reg_file, unsigned _reg_nr)
>           string(file, "ip");
>           return -1;
>           break;
> +      case BRW_ARF_TDR:
> +         format(file, "tdr");

Maybe print "tdr0" to match the docs?

> +         return -1;
> +      case BRW_ARF_TIMESTAMP:
> +         format(file, "tm%d", _reg_nr & 0x0f);

_reg_nr *should* always be 0, unless it's invalid.  Maybe just print "tm0"?

Either way, this is a clear improvement over ARF192!
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

> +         break;
>        default:
>           format(file, "ARF%d", _reg_nr);
>           break;
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20141103/88aca920/attachment.sig>


More information about the mesa-dev mailing list