[Mesa-dev] [PATCH 3/3] i965: Re-enable Z16 on Gen8+.

[Kristian Høgsberg]

On Wed, Oct 22, 2014 at 8:58 AM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> Improves performance in GLBenchmark 2.7 TRex by 3.88889% +/- 0.336383%
> (n=80) at 1280x720 on Broadwell GT3.  Together with the previous patch,
> it improves performance by 5.42738% +/- 0.541971% (n=10) at 1920x1080.
>
> Note that without the PMA stall fix, this would instead decrease
> performance by 22%.
>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/drivers/dri/i965/brw_surface_formats.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_surface_formats.c b/src/mesa/drivers/dri/i965/brw_surface_formats.c
> index 5407ef6..ce6f88c 100644
> --- a/src/mesa/drivers/dri/i965/brw_surface_formats.c
> +++ b/src/mesa/drivers/dri/i965/brw_surface_formats.c
> @@ -619,6 +619,8 @@ brw_init_surface_formats(struct brw_context *brw)
>     brw->format_supported_as_render_target[MESA_FORMAT_S_UINT8] = true;
>     brw->format_supported_as_render_target[MESA_FORMAT_Z_FLOAT32] = true;
>     brw->format_supported_as_render_target[MESA_FORMAT_Z32_FLOAT_S8X24_UINT] = true;
> +   if (brw->gen >= 8)
> +      brw->format_supported_as_render_target[MESA_FORMAT_Z_UNORM16] = true;
>
>     /* We remap depth formats to a supported texturing format in
>      * translate_tex_format().
> @@ -639,6 +641,8 @@ brw_init_surface_formats(struct brw_context *brw)
>      * Other speculation is that we may be hitting increased fragment shader
>      * execution from GL_LEQUAL/GL_EQUAL depth tests at reduced precision.
>      */
> +   if (brw->gen >= 8)
> +      ctx->TextureFormatSupported[MESA_FORMAT_Z_UNORM16] = true;

Edit the comment above to mention that we get the expected performance
with the pma stall workaround?

Either way,

Reviewed-by: Kristian Høgsberg <krh at bitplanet.net>

>     /* On hardware that lacks support for ETC1, we map ETC1 to RGBX
>      * during glCompressedTexImage2D(). See intel_mipmap_tree::wraps_etc1.
> --
> 2.1.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev