[Mesa-dev] [PATCH] mesa: Remove _mesa_max_buffer_index

Kenneth Graunke kenneth at whitecape.org
Thu Nov 6 23:47:33 PST 2014


On Thursday, November 06, 2014 11:00:13 PM Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> It appears to be completely unused since f9be8543 (February 2012).
> 
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> Cc: Kenneth Graunke <kenneth at whitecape.org>

Yep, looks unused to me.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

My 2012 commit message in f9be8543 is not quite true - glDrawRangeElements is 
actually useful even when working with VBOs.  The driver can use the given 
range to decide what portion of a VBO is busy/going to be read by the GPU.  It 
can then optimize glBufferSubData and glMapBufferRange to avoid unnecessary 
synchronization when an application tries to overwrite an unused subregion.

It turns out that's also rather crucial for performance in many modern apps.

--Ken
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20141106/38a38a6e/attachment.sig>


More information about the mesa-dev mailing list