[Mesa-dev] [PATCH 1/2] clover: fix tab/space and alignement

EdB edb+mesa at sigluy.net
Mon Nov 10 23:44:45 PST 2014


On Monday 10 November 2014 19:03:43 Francisco Jerez wrote:
> EdB <edb+mesa at sigluy.net> writes:
> > ---
> > 
> >  src/gallium/state_trackers/clover/llvm/invocation.cpp | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp
> > b/src/gallium/state_trackers/clover/llvm/invocation.cpp index
> > 3a4fcf0..d29f5a6 100644
> > --- a/src/gallium/state_trackers/clover/llvm/invocation.cpp
> > +++ b/src/gallium/state_trackers/clover/llvm/invocation.cpp
> > @@ -214,7 +214,7 @@ namespace {
> > 
> >  #if HAVE_LLVM >= 0x0306
> >  
> >        c.getPreprocessorOpts().addRemappedFile(name,
> > 
> > -                                             
> > llvm::MemoryBuffer::getMemBuffer(source).release()); +                   
> >                   llvm::MemoryBuffer::getMemBuffer(source).release());
> This doesn't to fix the inconsistency that the line goes over the 80
> column limit, if that's what you meant to fix, and it makes the
> alignment with the open parenthesis inconsistent.

 
I tried to make it consistent with the bottom line.
Please use the style that fit better

EdB

> 
> >  #else
> >  
> >        c.getPreprocessorOpts().addRemappedFile(name,
> >        
> >                                        llvm::MemoryBuffer::getMemBuffer(so
> >                                        urce));
> > 
> > @@ -675,7 +675,7 @@ static const struct debug_named_value debug_options[]
> > = {> 
> >     {"llvm", DBG_LLVM, "Dump the generated LLVM IR for all kernels."},
> >     {"asm", DBG_ASM, "Dump kernel assembly code for targets specifying "
> >     
> >                      "PIPE_SHADER_IR_NATIVE"},
> > 
> > -	DEBUG_NAMED_VALUE_END // must be last
> > +   DEBUG_NAMED_VALUE_END // must be last
> > 
> >  };
> >  
> >  module
> > 
> > @@ -737,7 +737,7 @@ clover::compile_program_llvm(const compat::string
> > &source,> 
> >           break;
> >        
> >        case PIPE_SHADER_IR_NATIVE: {
> >        
> >           std::vector<char> code = compile_native(mod, triple, processor,
> > 
> > -	                                         debug_flags & DBG_ASM, 
r_log);
> > +                                                 debug_flags & DBG_ASM,
> > r_log);> 
> >           m = build_module_native(code, mod, kernels, address_spaces,
> >           r_log);
> >           break;
> >        
> >        }
> > 
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/mesa-dev



More information about the mesa-dev mailing list