[Mesa-dev] [PATCH] nvc0: remove unused nvc0_screen::mm_VRAM_fe0

Alexandre Courbot gnurou at gmail.com
Tue Nov 11 20:59:56 PST 2014


Ping, how about this guy?

On Mon, Oct 27, 2014 at 7:36 PM, Alexandre Courbot <acourbot at nvidia.com> wrote:
> This member is declared, allocated and destroyed, but doesn't seem to be
> used or referenced anywhere in the code.
>
> Signed-off-by: Alexandre Courbot <acourbot at nvidia.com>
> ---
> Resending after fixing typo in email address - apologies for the inconvenience.
>
>  src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 3 ---
>  src/gallium/drivers/nouveau/nvc0/nvc0_screen.h | 2 --
>  2 files changed, 5 deletions(-)
>
> diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
> index a7581f286cfc..61b381693224 100644
> --- a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
> +++ b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
> @@ -407,8 +407,6 @@ nvc0_screen_destroy(struct pipe_screen *pscreen)
>
>     FREE(screen->tic.entries);
>
> -   nouveau_mm_destroy(screen->mm_VRAM_fe0);
> -
>     nouveau_object_del(&screen->eng3d);
>     nouveau_object_del(&screen->eng2d);
>     nouveau_object_del(&screen->m2mf);
> @@ -1027,7 +1025,6 @@ nvc0_screen_create(struct nouveau_device *dev)
>
>     mm_config.nvc0.tile_mode = 0;
>     mm_config.nvc0.memtype = 0xfe0;
> -   screen->mm_VRAM_fe0 = nouveau_mm_create(dev, NOUVEAU_BO_VRAM, &mm_config);
>
>     if (!nvc0_blitter_create(screen))
>        goto fail;
> diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.h b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.h
> index 4802057f70ee..8a1991f52eb4 100644
> --- a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.h
> +++ b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.h
> @@ -73,8 +73,6 @@ struct nvc0_screen {
>        boolean mp_counters_enabled;
>     } pm;
>
> -   struct nouveau_mman *mm_VRAM_fe0;
> -
>     struct nouveau_object *eng3d; /* sqrt(1/2)|kepler> + sqrt(1/2)|fermi> */
>     struct nouveau_object *eng2d;
>     struct nouveau_object *m2mf;
> --
> 2.1.2
>


More information about the mesa-dev mailing list