[Mesa-dev] Removing unused opcodes (TGSI, Mesa IR)

Ilia Mirkin imirkin at alum.mit.edu
Thu Nov 13 09:13:23 PST 2014


As long as we have NAND, pretty much anything can be lowered to
that... I am, of course, not advocating keeping around every insane
instruction, but it does seem a bit arbitrary as to which ones we have
and which ones we don't... I am personally guilty of adding a bunch,
and it was never clear to me how much should be left to the backend
optimizer to un-lower and how much should be done as separate
instructions.

My take was that as long there was a state tracker providing it as
input, it made sense to keep the instruction. But perhaps there's a
different policy that'd work better.

Cheers,

  -ilia


On Thu, Nov 13, 2014 at 11:40 AM, Marek Olšák <maraeo at gmail.com> wrote:
> Nine can lower ARR into ROUND+ARL easily.
>
> Marek
>
> On Thu, Nov 13, 2014 at 3:33 PM, Jose Fonseca <jfonseca at vmware.com> wrote:
>> It looks like ARR is generated, as src/gallium/state_trackers/nine/nine_shader.c has
>>
>> #define _OPI(o,t,vv1,vv2,pv1,pv2,d,s,h) \
>>     { D3DSIO_##o, TGSI_OPCODE_##t, { vv1, vv2 }, { pv1, pv2, }, d, s, h }
>>
>> [...]
>>
>>   _OPI(MOVA, ARR, V(2,0), V(3,0), V(0,0), V(0,0), 1, 1, NULL),
>>
>>
>> Jose
>>
>> ________________________________________
>> From: mesa-dev <mesa-dev-bounces at lists.freedesktop.org> on behalf of Eric Anholt <eric at anholt.net>
>> Sent: 13 November 2014 01:43
>> To: Ilia Mirkin
>> Cc: mesa-dev at lists.freedesktop.org
>> Subject: Re: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR)
>>
>> Ilia Mirkin <imirkin at alum.mit.edu> writes:
>>
>>> AFAIK at least some of these (NRM, ARR, probably others) were being used by
>>> the d3d9 state tracker. Not sure what its status is, but I believe the hope
>>> was to eventually get it into the tree.
>>
>> They've got code for lowering NRM and CND to sanity, and no use of ARR,
>> ARA, X2D, RFL, STR, SFL, or BRA.
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list