[Mesa-dev] Removing unused opcodes (TGSI, Mesa IR)
Roland Scheidegger
sroland at vmware.com
Thu Nov 13 13:33:16 PST 2014
FWIW opencl explicit conversion instructions have optional rounding mode
modifiers.
Roland
Am 13.11.2014 um 21:19 schrieb Jose Fonseca:
> I've eliminated our internal dependency on TGSI_OPCODE_CND (by replacing SUB+CMP). So you can commit the change to remove it as far as I'm concerned.
>
> I have mixed feelings about ARR, because the operation it does is essentially an "iround()", i.e., "(int)roundf()", and at least when targeting x86, we can generate better code with the combination.
>
> That said neither D3D10, GLSL, or OpenCL C code has built-ins for iround(), so to be of benefit we'd need to do pattern matching. So I'm not sure if it's worth to keep this around just for that...
>
> Jose
>
> ________________________________________
> From: Jose Fonseca
> Sent: 13 November 2014 13:06
> To: Eric Anholt; mesa-dev at lists.freedesktop.org
> Subject: RE: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR)
>
> Thanks for doing this. It's has been long overdue.
>
> Unfortunately we are relying on TGSI_OPCODE_CND/TGSI_OPCODE_ARR internally. I'm also interested in cutting down used opcodes, so I'll try to replace their usage with something else. But until then please hold on to those two patches.
>
> The rest looks good AFAICT.
>
> Concerning subroutines, we rely on BGNSUB/ENDSUB/CAL extensively. They are quite convenient when translating D3D 9/10 shaders, which also have them. And if one day we need to support recursive subroutines (CUDA 4.0 appears to have them; not sure about OpenCL, but I suppose it's only a matter of time), then they'll be unavoidable, as in-lining subroutines won't work anymore.
>
> Jose
>
>
>
> ________________________________________
> From: mesa-dev <mesa-dev-bounces at lists.freedesktop.org> on behalf of Eric Anholt <eric at anholt.net>
> Sent: 13 November 2014 01:18
> To: mesa-dev at lists.freedesktop.org
> Subject: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR)
>
> This series removes a bunch of unused opcodes, mostly from TGSI. It
> doesn't go as far as we could possibly go -- while I welcome discussion
> for future patch series deleting more, I hope that discussion doesn't
> derail the review process for these changes.
>
> I haven't messed with the subroutine stuff, since I don't know what people
> are planning with that. I also haven't messed with the pack/unpack
> opcodes in TGSI, since they might be useful for some of the GLSL packing
> stuff.
>
> Testing status: compile-tested ilo/r600/softpipe, touch-tested softpipe.
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.freedesktop.org_mailman_listinfo_mesa-2Ddev&d=AAIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=zfmBZnnVGHeYde45pMKNnVyzeaZbdIqVLprmZCM2zzE&m=KrBch2e5-gJGE_5bIs9RInABCFoKy7me_0oysUie4JI&s=w3G1SjuOy0EbCJjVrC1tDok52z4eMzIiKu63rvxI7SY&e=
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.freedesktop.org_mailman_listinfo_mesa-2Ddev&d=AAIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=Vjtt0vs_iqoI31UfJxBl7yv9I2FeiaeAYgMTLKRBc_I&m=5I_PKJFWlfqxJa2pURZQFykxOixuGPmVNdNc0FEBojM&s=cacpp7IDyYxBIzOO6UYU6IzVdrr6EoyBV66p1rS2Vu0&e=
>
More information about the mesa-dev
mailing list