[Mesa-dev] [PATCH] i965: Don't call _mesa_load_state_parameters when nr_params == 0.

[Matt Turner]

On Thu, Nov 13, 2014 at 11:22 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> Saves a tiny bit of CPU overhead.
>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/drivers/dri/i965/brw_vs_surface_state.c | 10 +++++-----
>  src/mesa/drivers/dri/i965/gen6_vs_state.c        | 12 ++++++------
>  2 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_vs_surface_state.c b/src/mesa/drivers/dri/i965/brw_vs_surface_state.c
> index 1cc96cf..4e18c7d 100644
> --- a/src/mesa/drivers/dri/i965/brw_vs_surface_state.c
> +++ b/src/mesa/drivers/dri/i965/brw_vs_surface_state.c
> @@ -59,11 +59,6 @@ brw_upload_pull_constants(struct brw_context *brw,
>     int i;
>     uint32_t surf_index = prog_data->binding_table.pull_constants_start;
>
> -   /* Updates the ParamaterValues[i] pointers for all parameters of the
> -    * basic type of PROGRAM_STATE_VAR.
> -    */
> -   _mesa_load_state_parameters(&brw->ctx, prog->Parameters);
> -
>     if (!prog_data->nr_pull_params) {

This check is different from the one below and what the commit summary says.

Assuming that's what you expected

Reviewed-by: Matt Turner <mattst88 at gmail.com>