[Mesa-dev] [PATCH v2 10/16] i965: Rename brw_vec4_prog_data to brw_vue_prog_data

Kenneth Graunke kenneth at whitecape.org
Fri Nov 14 16:39:07 PST 2014

On Thursday, November 13, 2014 04:28:16 PM Kristian Høgsberg wrote:
> With scalar vertex shader coming up, we're going to reuse brw_vec4_prog_data
> in the scalar backend.  There's nothing vec4 specific in the struct, it's
> instead common state for stages that operate on VUEs.  This patch renames
> the struct to brw_vue_prog_data which is more descriptive and will look a lot
> less awkward when we use it in the scalar backend.
> Signed-off-by: Kristian Høgsberg <krh at bitplanet.net>
> diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/brw_vec4.cpp
> index df589b8..280db47 100644
> --- a/src/mesa/drivers/dri/i965/brw_vec4.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_vec4.cpp
> @@ -1911,9 +1911,9 @@ brw_vs_emit(struct brw_context *brw,
>  void
> -brw_vec4_setup_prog_key_for_precompile(struct gl_context *ctx,
> -                                       struct brw_vec4_prog_key *key,
> -                                       GLuint id, struct gl_program *prog)
> +brw_vue_setup_prog_key_for_precompile(struct gl_context *ctx,
> +                                      struct brw_vue_prog_key *key,
> +                                      GLuint id, struct gl_program *prog)
>  {

You've renamed this function without renaming any of its callers.

Applying this patch leads to an unloadable driver with missing symbols:

libGL: pci id for fd 4: 8086:0d26, driver i965
libGL: OpenDriver: trying /home/kwg/Projects/mesa/lib/tls/i965_dri.so
libGL: OpenDriver: trying /home/kwg/Projects/mesa/lib/i965_dri.so
libGL: dlopen /home/kwg/Projects/mesa/lib/i965_dri.so failed (/home/kwg/Projects/mesa/lib/i965_dri.so: undefined symbol: brw_vec4_setup_prog_key_for_precompile)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20141114/422e348a/attachment.sig>

More information about the mesa-dev mailing list