[Mesa-dev] [PATCH 2/2] Revert "mesa: Wrap SSE4.1 code in #ifdef __SSE4_1__."

David Heidelberg david at ixit.cz
Sat Nov 15 10:09:23 PST 2014


Apply for both patch 1/2 and 2/2.

Host: chroot on AMD A3870K
Target: AMD TK-55 (compiled with -mno-sse41)

I tested chroot cross-compilation and it passed correctly.

Tested-by: David Heidelberg <david at ixit.cz>
On 11/15/2014 06:04 PM, Emil Velikov wrote:
> This reverts commit 8d3f739383fbdf671752fdec707f1c2b9b2aa6a3.
>
> In the last commit we've updated our check to determine if the actual
> code is buildable, rather than if the compiler acknowledges the option.
> I.e. did anyone provide -mno-sse4.1 vs is my compiler too old.
>
> Now this code will never be attemped to be build, in both cases.
>
> Confirmed by building mesa with
> export CFLAGS='-march=native -mno-sse4.1'
> configure && make
>
> Cc: Matt Turner <mattst88 at gmail.com>
> Cc: David Heidelberger <david at ixit.cz>
> ---
>   src/mesa/main/streaming-load-memcpy.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/src/mesa/main/streaming-load-memcpy.c b/src/mesa/main/streaming-load-memcpy.c
> index 8427149..d7147af 100644
> --- a/src/mesa/main/streaming-load-memcpy.c
> +++ b/src/mesa/main/streaming-load-memcpy.c
> @@ -26,7 +26,6 @@
>    *
>    */
>   
> -#ifdef __SSE4_1__
>   #include "main/macros.h"
>   #include "main/streaming-load-memcpy.h"
>   #include <smmintrin.h>
> @@ -84,5 +83,3 @@ _mesa_streaming_load_memcpy(void *restrict dst, void *restrict src, size_t len)
>         memcpy(d, s, len);
>      }
>   }
> -
> -#endif



More information about the mesa-dev mailing list