[Mesa-dev] [PATCH] mesa/main: Fix tmp_row memory leak in texstore_rgba_integer.

Jason Ekstrand jason at jlekstrand.net
Sat Nov 15 11:36:39 PST 2014


Good catch!

Reviewed-by: Jason Ekstrand <jason.ekstrand at intel.com>

Can you push or do you need me to?

On Sat, Nov 15, 2014 at 11:02 AM, Siavash Eliasi <siavashserver at gmail.com>
wrote:

> ---
>  src/mesa/main/texstore.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/main/texstore.c b/src/mesa/main/texstore.c
> index f913e42..f858cef 100644
> --- a/src/mesa/main/texstore.c
> +++ b/src/mesa/main/texstore.c
> @@ -1667,8 +1667,10 @@ texstore_rgba_integer(TEXSTORE_PARAMS)
>
>     assert(is_array && !normalized);
>
> -   if (!is_array)
> +   if (!is_array) {
> +      free(tmp_row);
>        return GL_FALSE;
> +   }
>
>     invert_swizzle(dst2rgba, rgba2dst);
>     compute_component_mapping(GL_RGBA, baseInternalFormat, base2rgba);
> --
> 2.1.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20141115/ea6a85c6/attachment.html>


More information about the mesa-dev mailing list