[Mesa-dev] [PATCH] scons: Require glproto >= 1.4.13 for X11.

[Matt Turner]

On Sat, Nov 15, 2014 at 2:16 PM, Vinson Lee <vlee at freedesktop.org> wrote:
> GLXBadProfileARB and X_GLXCreateContextAtrribsARB require glproto >=
> 1.4.13. These symbols were added in commit
> d5d41112cbccd9301500e8e023be77eb9cb622cd "st/xlib: Generate errors as
> specified."
>
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> Cc: "10.4" <mesa-stable at lists.freedesktop.org>
> ---
>  scons/gallium.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scons/gallium.py b/scons/gallium.py
> index e3786d2..4df6e1a 100755
> --- a/scons/gallium.py
> +++ b/scons/gallium.py
> @@ -621,7 +621,7 @@ def generate(env):
>      env.Tool('custom')
>      createInstallMethods(env)
>
> -    env.PkgCheckModules('X11', ['x11', 'xext', 'xdamage', 'xfixes'])
> +    env.PkgCheckModules('X11', ['x11', 'xext', 'xdamage', 'xfixes', 'glproto >= 1.4.13'])
>      env.PkgCheckModules('XCB', ['x11-xcb', 'xcb-glx >= 1.8.1', 'xcb-dri2 >= 1.8'])
>      env.PkgCheckModules('XF86VIDMODE', ['xxf86vm'])
>      env.PkgCheckModules('DRM', ['libdrm >= 2.4.38'])
> --
> 1.9.2

The autotools build system has required 1.4.14 since 2011 -- see
commit 1e39fc784bc.

It's not clear to me why this difference wouldn't have shown up before.