[Mesa-dev] [PATCH 1/3] nine: Don't use the otherwise-dead SFL opcode in an unreachable path.

[Axel Davy]

Hi,

Series looks good. You can add my r-b.

Do you want also to remove the DP2A reference like
did Jose patch ?

Axel Davy

On 20/11/2014 23:31, Eric Anholt wrote :
> ---
>   src/gallium/state_trackers/nine/nine_shader.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/state_trackers/nine/nine_shader.c b/src/gallium/state_trackers/nine/nine_shader.c
> index cc027b4..9b324c3 100644
> --- a/src/gallium/state_trackers/nine/nine_shader.c
> +++ b/src/gallium/state_trackers/nine/nine_shader.c
> @@ -1615,7 +1615,7 @@ sm1_insn_flags_to_tgsi_setop(BYTE flags)
>       case NINED3DSHADER_REL_OP_LE: return TGSI_OPCODE_SLE;
>       default:
>           assert(!"invalid comparison flags");
> -        return TGSI_OPCODE_SFL;
> +        return TGSI_OPCODE_SGT;
>       }
>   }
>