[Mesa-dev] [PATCH 1/2] i965: Extract depctrl hazards

Matt Turner mattst88 at gmail.com
Fri Nov 21 11:20:59 PST 2014


On Fri, Nov 21, 2014 at 11:18 AM, Ben Widawsky <ben at bwidawsk.net> wrote:
> On Fri, Nov 21, 2014 at 11:04:18AM -0800, Matt Turner wrote:
>> On Fri, Nov 21, 2014 at 10:50 AM, Ben Widawsky
>> <benjamin.widawsky at intel.com> wrote:
>> > +    */ +   return !(inst->mlen || inst->predicate || inst->is_math());
>>
>> The return value is a ! expression, and below our only caller is inverting the
>> result. I'd probably just make it is_dep_ctrl_unsafe() or something.
>
> I liked the sound of _safe better (and it fits in with my eventual plans better,
> should I actually get around to it). It's fine with me to change it.

Okay, either way.


More information about the mesa-dev mailing list