[Mesa-dev] [PATCH 2/2] i965/draw state: Allow state upload to proceed when inputs are not set

[Ben Widawsky]

On Sat, Nov 22, 2014 at 12:02:31PM -0800, Jordan Justen wrote:
> For drawing the OpenGL API should validate this before we try to upload the
> state.
> 
> For compute, these might not be set.
> 
> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
> ---
>  src/mesa/drivers/dri/i965/brw_draw_upload.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_draw_upload.c b/src/mesa/drivers/dri/i965/brw_draw_upload.c
> index 5a12439..28136e2 100644
> --- a/src/mesa/drivers/dri/i965/brw_draw_upload.c
> +++ b/src/mesa/drivers/dri/i965/brw_draw_upload.c
> @@ -433,6 +433,10 @@ brw_prepare_vertices(struct brw_context *brw)
>        struct brw_vertex_element *input = &brw->vb.inputs[i];
>  
>        vs_inputs &= ~BITFIELD64_BIT(i);
> +
> +      if (!input->glarray)
> +         continue;
> +
>        brw->vb.enabled[brw->vb.nr_enabled++] = input;
>     }
>  

Do you have any sort of design doc for this somewhere? I was under the
impression you'd be using the GPGPU pipe, and therefore it wouldn't make sense
to even use the same atoms. I would have expected something like a
compute_atoms[].

Sorry that I have no context on this. Forgive me if this is a stupid
interjections.

-- 
Ben Widawsky, Intel Open Source Technology Center