[Mesa-dev] [PATCH 01/10] i965: Alphabetize brw_tracked_state flags and use a consistent style.

Matt Turner mattst88 at gmail.com
Tue Nov 25 14:38:12 PST 2014

On Tue, Nov 25, 2014 at 4:43 AM, Kenneth Graunke <kenneth at whitecape.org> wrote:

> 4:43 AM

If I didn't see you a couple of times a week I'd wonder what timezone
you were in!

> Most of the dirty flags were listed in some arbitrary order.  Some used
> bonus parenthesis.  Some put multiple flags on one line, others put one
> per line.  Some used tabs instead of spaces...but only on some lines.
> This patch settles on one flag per line, in alphabetical order, using
> spaces instead of tabs, and sheds the unnecessary parentheses.
> Sorting was mostly done with vim's visual block feature and !sort,
> although I alphabetized short lists by hand; it was pretty manual.
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>

1-7, the non-scripted parts of 9, and 10 are (Yes, I actually reviewed #1)

Reviewed-by: Matt Turner <mattst88 at gmail.com>

8 and the scripted parts of 9 are

Acked-by: Matt Turner <mattst88 at gmail.com>

More information about the mesa-dev mailing list