[Mesa-dev] [PATCH 0/7] util: Move u_atomic.h to src/util and modify API

Jose Fonseca jfonseca at vmware.com
Wed Nov 26 02:15:02 PST 2014


On 26/11/14 01:01, Matt Turner wrote:
> On Mon, Nov 24, 2014 at 4:39 PM, Matt Turner <mattst88 at gmail.com> wrote:
>> I've got some thread-safety fixes queued up after this and thought I'd
>> be a good Mesa citizen and pull some code into src/util.
>>
>> I did some clean ups like replacing INLINE (MSVC knows about "inline"
>> these days, right?) and used stdbool.h instead of the "boolean" type.
>>
>> I also removed the inline assembly implementations because they were
>> either dead code, or only allowed *ancient* gcc to build Mesa and
>> because I didn't want to update them for the next patch, which makes
>> the API consist of some macros that internally do the right operation
>> based on the type.
>>
>> The last patch looks funky, but I think it's actually a reasonable
>> solution. I don't have MSVC or Sun Studio, so please give this a
>> test.
>
> With José's fixes merged in, I've pushed a branch to
>
>      git://people.freedesktop.org/~mattst88/mesa thread-safe
>
> Feel free to ignore the patches on top of this series.
Looks great.

Reviewed-by: Jose Fonseca <jfonseca at vmware.com>



More information about the mesa-dev mailing list