[Mesa-dev] [PATCH] gallium/hud: use u_sampler_view_default_template helper

Marek Olšák maraeo at gmail.com
Thu Oct 2 02:30:18 PDT 2014


Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Marek

On Thu, Oct 2, 2014 at 1:45 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> The existing code was not setting several fields, most importantly the
> target, which is required on nv50/nvc0.
>
> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> ---
>  src/gallium/auxiliary/hud/hud_context.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxiliary/hud/hud_context.c
> index b6e0184..18a8781 100644
> --- a/src/gallium/auxiliary/hud/hud_context.c
> +++ b/src/gallium/auxiliary/hud/hud_context.c
> @@ -44,6 +44,7 @@
>  #include "util/u_inlines.h"
>  #include "util/u_memory.h"
>  #include "util/u_math.h"
> +#include "util/u_sampler.h"
>  #include "util/u_simple_shaders.h"
>  #include "util/u_string.h"
>  #include "util/u_upload_mgr.h"
> @@ -1050,12 +1051,8 @@ hud_create(struct pipe_context *pipe, struct cso_context *cso)
>     }
>
>     /* sampler view */
> -   memset(&view_templ, 0, sizeof(view_templ));
> -   view_templ.format = hud->font.texture->format;
> -   view_templ.swizzle_r = PIPE_SWIZZLE_RED;
> -   view_templ.swizzle_g = PIPE_SWIZZLE_GREEN;
> -   view_templ.swizzle_b = PIPE_SWIZZLE_BLUE;
> -   view_templ.swizzle_a = PIPE_SWIZZLE_ALPHA;
> +   u_sampler_view_default_template(
> +         &view_templ, hud->font.texture, hud->font.texture->format);
>     hud->font_sampler_view = pipe->create_sampler_view(pipe, hud->font.texture,
>                                                        &view_templ);
>
> --
> 1.8.5.5
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list