[Mesa-dev] [PATCH] glsl/glsl_parser_extras: Handle GLSL 4.50

[Olivier Galibert]

Sorry for not replying earlier, I didn't see your answer.

On Thu, Sep 4, 2014 at 12:33 AM, Matt Turner <mattst88 at gmail.com> wrote:
> Did you change the leading whitespace on purpose?

Not really, I can un-change that.  I have an emacs config that's
supposedly what mesa wants, but it may be incorrect.


>> -   } supported_versions[12];
>> +   } supported_versions[14];
>
> Where does this number come from, and can we make it a little clearer
> what it is?

It's the maximum number of simultaneous glsl versions that a driver
can support.  With the current code it should be 13, that is, if a
driver supports glsl 440 it's going to segfault writing after the end
of array.  Supporting 450 needs one more.

Note that it's not (yet) a security issue since the largest we support is 330.

Best,

  OG.