[Mesa-dev] [PATCH] Revert "configure: ask vdpau.pc for the default location of the vdpau drivers"

[Jan Vesely]

On Sun, 2014-09-28 at 16:13 -0400, Ilia Mirkin wrote:
> On Sun, Sep 28, 2014 at 4:09 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> > On 28/09/14 20:08, Emil Velikov wrote:
> >> On 28/09/14 19:04, Ilia Mirkin wrote:
> >>> On Sun, Sep 28, 2014 at 1:35 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> > [snip]
> >>> This, however, has nothing to do with mesa. When I set --prefix,
> >>> that's saying "hey, install here". Not "hey, install here for most
> >>> things, but actually overwrite my system install for other things".
> >>>
> >> The point is if we are to revert this, we have to nuke the equivalent
> >> omx and va ones. Afaics there is no middle ground - either we keep the
> >> commit or add some default and hope that distros and anyone building
> >> mesa will bother correcting their config. Are you volunteering to hold
> >> everyone's hand during the transition ?
> >>
> > Had this idea, but I'm not too trilled about it:
> > Default = blank, and error out if the user did not set it. The error
> > message will state how to get it of course :)
> > This approach is not ideal but in a way it covers the "all must adhere
> > prefix" and prevents the case of xx reports on the topic "vdpau/omx is
> > broken".
> >
> > Thoughts ?
> 
> What was wrong with the thing we did before that worked fine for
> everyone in all cases? Use ${prefix}/lib/vdpau, allow people to
> override if they want something funky?

this might be a stupid question, but why not just replace system prefix
with specified prefix in --variable=moduledir ?

that way it installs to the correct directory if you don't specify
prefix and remains contained within prefix if you do.
Moreover, it makes your ${prefix} mimic your distro layout which is imo
desirable.

jan

> 
>   -ilia
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev

-- 
Jan Vesely <jan.vesely at rutgers.edu>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20141006/8722396f/attachment.sig>