[Mesa-dev] [PATCH] mesa: Make _mesa_print_arrays use stderr.

Tapani Pälli tapani.palli at intel.com
Wed Oct 8 01:31:38 PDT 2014


On 10/08/2014 11:24 AM, Kenneth Graunke wrote:
> These days, most driver debug output happens via stderr, not stdout.
> Some applications (such as Xephyr) also appear to close stdout which
> makes these messages go nowhere.

There's some more debug code using printf there (at least in uniform and
texture code), not sure if you want all of these to be changed (?)

Reviewed-by: Tapani Pälli <tapani.palli at intel.com>

> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/main/varray.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c
> index 09bf52c..96c2b26 100644
> --- a/src/mesa/main/varray.c
> +++ b/src/mesa/main/varray.c
> @@ -1907,10 +1907,10 @@ static void
>  print_array(const char *name, GLint index, const struct gl_client_array *array)
>  {
>     if (index >= 0)
> -      printf("  %s[%d]: ", name, index);
> +      fprintf(stderr, "  %s[%d]: ", name, index);
>     else
> -      printf("  %s: ", name);
> -   printf("Ptr=%p, Type=0x%x, Size=%d, ElemSize=%u, Stride=%d, Buffer=%u(Size %lu)\n",
> +      fprintf(stderr, "  %s: ", name);
> +   fprintf(stderr, "Ptr=%p, Type=0x%x, Size=%d, ElemSize=%u, Stride=%d, Buffer=%u(Size %lu)\n",
>  	  array->Ptr, array->Type, array->Size,
>  	  array->_ElementSize, array->StrideB,
>  	  array->BufferObj->Name, (unsigned long) array->BufferObj->Size);



More information about the mesa-dev mailing list