[Mesa-dev] [PATCH 0/3] cl workdim v2

[Francisco Jerez]

Jan Vesely <jan.vesely at rutgers.edu> writes:

> [SNIP]
>> > 
>> > > I also don't like that this way there is no difference between
>> > > explicit and implicit kernel arguments. On the other hand it's simple,
>> > > and does not need additional per driver code.
>> > >
>> > Yeah...  We definitely want to hide these from the user, as e.g. the
>> > CL_KERNEL_NUM_ARGS param is required by the spec to return the number of
>> > arguments provided by the user, and we don't want the user to set
>> > implicit args, so it gets a bit messy.  I think I like better your
>> > original idea of passing them as launch_grid() arguments, even though
>> > the grid offset and dimension parameters are somewhat artificial from a
>> > the hardware's point of view.
>> 
>> sorry to bug you some more with this. I tried one more thing before
>> going back to the launch_grid parameters. this time it implements a
>> parallel infrastructure for implicit arguments by creating artificial
>> module arguments for uint and size_t (I don't think we need more for
>> implicit arguments).
>> 
>> I only added the work dimension argument but adding more should be easy.
>> If you think that the launch_grid way is better, I'll stop experimenting
>> as I ran out of ideas I wanted to try.
>
> ping
> should I just resend using git instead of attachments?

Hi Jan, I'm sorry, I finally had a while to have a look into this.  I've
taken your series and tried to fix the couple of issues I wasn't very
comfortable with, see the attached series.  Does it look OK to you?
Note that it's completely untested, maybe you could give it a run on
your system?

Thanks.

>
>> 
>> thanks,
>> jan
>
> [SNIP]
>
> -- 
> Jan Vesely <jan.vesely at rutgers.edu>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-clover-Use-unreachable-from-util-macros.h-instead-of.patch
Type: text/x-diff
Size: 2148 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20141008/1bea5dcf/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-clover-Add-semantic-information-to-module-argument-f.patch
Type: text/x-diff
Size: 1941 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20141008/1bea5dcf/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-clover-Pass-execution-dimensions-and-offset-to-the-k.patch
Type: text/x-diff
Size: 6374 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20141008/1bea5dcf/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-clover-Append-implicit-arguments-to-the-kernel-argum.patch
Type: text/x-diff
Size: 3092 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20141008/1bea5dcf/attachment-0003.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 212 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20141008/1bea5dcf/attachment.sig>