[Mesa-dev] [PATCH 0/3] cl workdim v2

Francisco Jerez currojerez at riseup.net
Sun Oct 12 01:57:16 PDT 2014


Jan Vesely <jan.vesely at rutgers.edu> writes:

> On Sun, 2014-10-12 at 01:56 +0300, Francisco Jerez wrote:
>> >[...]
>> None in this case other than I tend to avoid switch-case statements
>> instinctively for some reason.  But detecting missing cases during
>> compile time sounds good, I've changed it to a switch.
>
> I think you forgot break; statements during the conversion.
> I tried enabling the errors/warning globally but it exploded in multiple
> places. I'll see if it can be used only for clover
>
Heh, this and the fact that you can only match by integral constant
expressions is precisely what I meant by some reason :P.  Anyway it's
fixed now.

>[...]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 212 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20141012/89807991/attachment-0001.sig>


More information about the mesa-dev mailing list