[Mesa-dev] [PATCH] st/gbm: fix arguments to is_format_supported

Michel Dänzer michel at daenzer.net
Mon Oct 13 23:15:23 PDT 2014


On 14.10.2014 11:42, Ilia Mirkin wrote:
> Reported by Coverity
>
> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> ---
>
> No idea how to test this, but seems pretty straightforward.
>
>   src/gallium/state_trackers/gbm/gbm_drm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/state_trackers/gbm/gbm_drm.c b/src/gallium/state_trackers/gbm/gbm_drm.c
> index bba3c05..da6d724 100644
> --- a/src/gallium/state_trackers/gbm/gbm_drm.c
> +++ b/src/gallium/state_trackers/gbm/gbm_drm.c
> @@ -85,7 +85,7 @@ gbm_gallium_drm_is_format_supported(struct gbm_device *gbm,
>      if (pf == PIPE_FORMAT_NONE)
>         return 0;
>
> -   if (!gdrm->screen->is_format_supported(gdrm->screen, PIPE_TEXTURE_2D, pf, 0,
> +   if (!gdrm->screen->is_format_supported(gdrm->screen, pf, PIPE_TEXTURE_2D, 0,
>                                             gbm_usage_to_gallium(usage)))
>         return 0;
>
>

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>


-- 
Earthling Michel Dänzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer


More information about the mesa-dev mailing list