[Mesa-dev] [PATCH] i965/fs: Use the correct regs_written on unspill instructions

Kenneth Graunke kenneth at whitecape.org
Tue Oct 14 12:33:23 PDT 2014


On Tuesday, October 14, 2014 12:03:00 PM Jason Ekstrand wrote:
> Signed-off-by: Jason Ekstrand <jason.ekstrand at intel.com>
> ---
>  src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp b/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp
> index 28a7483..46e465f 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp
> @@ -641,6 +641,7 @@ fs_visitor::emit_unspill(bblock_t *block, fs_inst *inst, fs_reg dst,
>        unspill_inst->offset = spill_offset;
>        unspill_inst->ir = inst->ir;
>        unspill_inst->annotation = inst->annotation;
> +      unspill_inst->regs_written = reg_size;
>  
>        if (!gen7_read) {
>           unspill_inst->base_mrf = 14;
> 

Right, this code lives in a loop that unspills large things in reg_size chunks.

Good catch.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20141014/27df1552/attachment.sig>


More information about the mesa-dev mailing list