[Mesa-dev] [PATCH 10/16] gallium/auxiliary: prefer intrinsic

[Roland Scheidegger]

On 10/18/2014 01:55 PM, David Heidelberger wrote:
> From: Christoph Bumiller <christoph.bumiller at speed.at>
>
> Signed-off-by: David Heidelberger <david.heidelberger at ixit.cz>
> ---
>   src/gallium/auxiliary/util/u_atomic.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/gallium/auxiliary/util/u_atomic.h b/src/gallium/auxiliary/util/u_atomic.h
> index 2f2b42b..b99ccc9 100644
> --- a/src/gallium/auxiliary/util/u_atomic.h
> +++ b/src/gallium/auxiliary/util/u_atomic.h
> @@ -24,12 +24,12 @@
>   #define PIPE_ATOMIC_MSVC_INTRINSIC
>   #elif (defined(PIPE_CC_MSVC) && defined(PIPE_ARCH_X86))
>   #define PIPE_ATOMIC_ASM_MSVC_X86
> +#elif (defined(PIPE_CC_GCC) && (PIPE_CC_GCC_VERSION >= 401))
> +#define PIPE_ATOMIC_GCC_INTRINSIC
>   #elif (defined(PIPE_CC_GCC) && defined(PIPE_ARCH_X86))
>   #define PIPE_ATOMIC_ASM_GCC_X86
>   #elif (defined(PIPE_CC_GCC) && defined(PIPE_ARCH_X86_64))
>   #define PIPE_ATOMIC_ASM_GCC_X86_64
> -#elif defined(PIPE_CC_GCC) && (PIPE_CC_GCC_VERSION >= 401)
> -#define PIPE_ATOMIC_GCC_INTRINSIC
>   #else
>   #error "Unsupported platform"
>   #endif
>

Is that somehow needed for gallium nine? This was already done a while 
ago and promptly reverted: 
https://bugs.freedesktop.org/show_bug.cgi?id=30514 at least I can't see 
why it would work better now, I think it would need some better detection.

Roland